ericholguin commented on code in PR #7453:
URL: https://github.com/apache/trafficcontrol/pull/7453#discussion_r1187534326
##########
traffic_ops/testing/api_contract/v4/request_template.json:
##########
@@ -55,5 +55,10 @@
{
"name": "RAM"
}
- ]
+ ],
+ "divisions":[
+ {
+ "name":"test"
+ }
+ ]
Review Comment:
Above 2 lines need tabs
##########
traffic_ops/testing/api_contract/v4/conftest.py:
##########
@@ -681,10 +681,9 @@ def server_capabilities_post_data(to_session: TOSession,
request_template_data:
:param to_session: Fixture to get Traffic Ops session.
:param request_template_data: Fixture to get server_capabilities data
from a prerequisites file.
- :returns: Sample POST data and the actual API response.
+ :returns: Sample POST data and the actual API response.
Review Comment:
Not sure why the tabbing was removed here?
##########
traffic_ops/testing/api_contract/v4/conftest.py:
##########
@@ -716,3 +715,49 @@ def server_capabilities_post_data(to_session: TOSession,
request_template_data:
except IndexError:
logger.error("No server_capabilities response data from
server_capabilities POST request.")
sys.exit(1)
+
+
[email protected]()
+def division_post_data(to_session: TOSession, request_template_data:
list[JSONData]
+ ) -> dict[str, object]:
+ """
+ PyTest Fixture to create POST data for divisions endpoint.
+
+ :param to_session: Fixture to get Traffic Ops session.
+ :param request_template_data: Fixture to get divisions request template
data from
+ request_template file.
+ :returns: Sample POST data and the actual API response.
Review Comment:
Tab
##########
traffic_ops/testing/api_contract/v4/conftest.py:
##########
@@ -681,10 +681,9 @@ def server_capabilities_post_data(to_session: TOSession,
request_template_data:
:param to_session: Fixture to get Traffic Ops session.
:param request_template_data: Fixture to get server_capabilities data
from a prerequisites file.
- :returns: Sample POST data and the actual API response.
+ :returns: Sample POST data and the actual API response.
"""
-
- try:
+ try:
Review Comment:
Same thing here, tabbing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
