zrhoffman commented on code in PR #7459: URL: https://github.com/apache/trafficcontrol/pull/7459#discussion_r1187930070
########## experimental/traffic-portal/src/app/core/cdns/cdn-table/cdn-table.component.html: ########## @@ -0,0 +1,28 @@ +<!-- +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<mat-card class="table-page-content"> + <div class="search-container"> + <input type="search" name="fuzzControl" aria-label="Fuzzy Search CDNs" rowSelection="single" autofocus inputmode="search" role="search" accesskey="/" placeholder="Fuzzy Search" [formControl]="fuzzControl" (input)="updateURL()"/> + </div> + <tp-generic-table + [data]="cdns | async" + [cols]="columnDefs" + [fuzzySearch]="fuzzySubject" + context="cdns" + [contextMenuItems]="contextMenuItems" + (contextMenuAction)="handleContextMenu($event)"> + </tp-generic-table> +</mat-card> + +<button class="page-fab" mat-fab title="Create a new CDN" *ngIf="auth.hasPermission('CDN:CREATE')" routerLink="new"><mat-icon>add</mat-icon></button> Review Comment: Using an anchor in 16ab99ecba ########## experimental/traffic-portal/src/app/core/cdns/cdn-table/cdn-table.component.ts: ########## @@ -0,0 +1,248 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ +import { Component, OnInit } from "@angular/core"; +import { FormControl } from "@angular/forms"; +import { MatDialog } from "@angular/material/dialog"; +import { ActivatedRoute } from "@angular/router"; +import { ColDef } from "ag-grid-community"; +import { BehaviorSubject } from "rxjs"; +import { AlertLevel, ResponseCDN } from "trafficops-types"; + +import { CDNService } from "src/app/api"; +import { AlertService } from "src/app/shared/alert/alert.service"; +import { CurrentUserService } from "src/app/shared/current-user/current-user.service"; +import { + DecisionDialogComponent, + DecisionDialogData +} from "src/app/shared/dialogs/decision-dialog/decision-dialog.component"; +import type { ContextMenuActionEvent, ContextMenuItem } from "src/app/shared/generic-table/generic-table.component"; + +/** + * CDNTableComponent is the controller for the "CDNs" table. + */ +@Component({ + selector: "tp-cdn-table", + styleUrls: ["./cdn-table.component.scss"], + templateUrl: "./cdn-table.component.html", +}) +export class CDNTableComponent implements OnInit { + public cdns: Promise<ResponseCDN[]>; + + /* Definitions of the table's columns according to the ag-grid API */ + public columnDefs: ColDef[] = [ + { + field: "dnssecEnabled", + filter: "tpBooleanFilter", + headerName: "DNSSEC Enabled", + hide: false + }, + { + field: "domain", + filter: "agTextColumnFilter", + headerName: "Domain", + hide: false, + }, + { + field: "id", + filter: "agNumberColumnFilter", + headerName: "ID", + hide: true, + }, + { + field: "lastUpdated", + filter: "agDateColumnFilter", + headerName: "Last Updated", + hide: true + }, + { + field: "name", + filter: "agTextColumnFilter", + headerName: "Name", + hide: false, + }, + ]; + + /** + * Definitions for the context menu items (which act on augmented + * CDN data). + */ + public contextMenuItems: Array<ContextMenuItem<ResponseCDN>> = [ + { + href: (selectedRow): string => `/core/cdns/${selectedRow.id}`, + name: "Open in New Tab", + newTab: true + }, + { + href: (selectedRow): string => `/core/cdns/${selectedRow.id}` , + name: "Edit" + }, + { + action: "delete", + multiRow: false, + name: "Delete", + }, + { + action: "snapshot-diff", + multiRow: false, + name: "Diff Snapshot", + }, + { + action: "queue", + multiRow: false, + name: "Queue Server Updates" + }, + { + action: "dequeue", + multiRow: false, + name: "Clear Queued Updates" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/dnssec-keys` , + name: "Manage DNSSEC Keys" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/federations` , + name: "Manage Federations" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/delivery-services` , + name: "Manage Delivery Services" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/profiles?cdnName=${selectedRow.id}` , + name: "Manage Profiles" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/servers` , + name: "Manage Servers" + }, Review Comment: Enabled *Manage Servers* link in f6c1105beb ########## experimental/traffic-portal/src/app/core/cdns/cdn-table/cdn-table.component.ts: ########## @@ -0,0 +1,248 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ +import { Component, OnInit } from "@angular/core"; +import { FormControl } from "@angular/forms"; +import { MatDialog } from "@angular/material/dialog"; +import { ActivatedRoute } from "@angular/router"; +import { ColDef } from "ag-grid-community"; +import { BehaviorSubject } from "rxjs"; +import { AlertLevel, ResponseCDN } from "trafficops-types"; + +import { CDNService } from "src/app/api"; +import { AlertService } from "src/app/shared/alert/alert.service"; +import { CurrentUserService } from "src/app/shared/current-user/current-user.service"; +import { + DecisionDialogComponent, + DecisionDialogData +} from "src/app/shared/dialogs/decision-dialog/decision-dialog.component"; +import type { ContextMenuActionEvent, ContextMenuItem } from "src/app/shared/generic-table/generic-table.component"; + +/** + * CDNTableComponent is the controller for the "CDNs" table. + */ +@Component({ + selector: "tp-cdn-table", + styleUrls: ["./cdn-table.component.scss"], + templateUrl: "./cdn-table.component.html", +}) +export class CDNTableComponent implements OnInit { + public cdns: Promise<ResponseCDN[]>; + + /* Definitions of the table's columns according to the ag-grid API */ + public columnDefs: ColDef[] = [ + { + field: "dnssecEnabled", + filter: "tpBooleanFilter", + headerName: "DNSSEC Enabled", + hide: false + }, + { + field: "domain", + filter: "agTextColumnFilter", + headerName: "Domain", + hide: false, + }, + { + field: "id", + filter: "agNumberColumnFilter", + headerName: "ID", + hide: true, + }, + { + field: "lastUpdated", + filter: "agDateColumnFilter", + headerName: "Last Updated", + hide: true + }, + { + field: "name", + filter: "agTextColumnFilter", + headerName: "Name", + hide: false, + }, + ]; + + /** + * Definitions for the context menu items (which act on augmented + * CDN data). + */ + public contextMenuItems: Array<ContextMenuItem<ResponseCDN>> = [ + { + href: (selectedRow): string => `/core/cdns/${selectedRow.id}`, + name: "Open in New Tab", + newTab: true + }, + { + href: (selectedRow): string => `/core/cdns/${selectedRow.id}` , + name: "Edit" + }, + { + action: "delete", + multiRow: false, + name: "Delete", + }, + { + action: "snapshot-diff", + multiRow: false, + name: "Diff Snapshot", + }, + { + action: "queue", + multiRow: false, + name: "Queue Server Updates" + }, + { + action: "dequeue", + multiRow: false, + name: "Clear Queued Updates" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/dnssec-keys` , + name: "Manage DNSSEC Keys" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/federations` , + name: "Manage Federations" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/delivery-services` , + name: "Manage Delivery Services" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/profiles?cdnName=${selectedRow.id}` , + name: "Manage Profiles" + }, Review Comment: Enabled the *Manage Profiles* link in 29cca13661 ########## experimental/traffic-portal/src/app/core/cdns/cdn-table/cdn-table.component.ts: ########## @@ -0,0 +1,248 @@ +/* +* Licensed under the Apache License, Version 2.0 (the "License"); +* you may not use this file except in compliance with the License. +* You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ +import { Component, OnInit } from "@angular/core"; +import { FormControl } from "@angular/forms"; +import { MatDialog } from "@angular/material/dialog"; +import { ActivatedRoute } from "@angular/router"; +import { ColDef } from "ag-grid-community"; +import { BehaviorSubject } from "rxjs"; +import { AlertLevel, ResponseCDN } from "trafficops-types"; + +import { CDNService } from "src/app/api"; +import { AlertService } from "src/app/shared/alert/alert.service"; +import { CurrentUserService } from "src/app/shared/current-user/current-user.service"; +import { + DecisionDialogComponent, + DecisionDialogData +} from "src/app/shared/dialogs/decision-dialog/decision-dialog.component"; +import type { ContextMenuActionEvent, ContextMenuItem } from "src/app/shared/generic-table/generic-table.component"; + +/** + * CDNTableComponent is the controller for the "CDNs" table. + */ +@Component({ + selector: "tp-cdn-table", + styleUrls: ["./cdn-table.component.scss"], + templateUrl: "./cdn-table.component.html", +}) +export class CDNTableComponent implements OnInit { + public cdns: Promise<ResponseCDN[]>; + + /* Definitions of the table's columns according to the ag-grid API */ + public columnDefs: ColDef[] = [ + { + field: "dnssecEnabled", + filter: "tpBooleanFilter", + headerName: "DNSSEC Enabled", + hide: false + }, + { + field: "domain", + filter: "agTextColumnFilter", + headerName: "Domain", + hide: false, + }, + { + field: "id", + filter: "agNumberColumnFilter", + headerName: "ID", + hide: true, + }, + { + field: "lastUpdated", + filter: "agDateColumnFilter", + headerName: "Last Updated", + hide: true + }, + { + field: "name", + filter: "agTextColumnFilter", + headerName: "Name", + hide: false, + }, + ]; + + /** + * Definitions for the context menu items (which act on augmented + * CDN data). + */ + public contextMenuItems: Array<ContextMenuItem<ResponseCDN>> = [ + { + href: (selectedRow): string => `/core/cdns/${selectedRow.id}`, + name: "Open in New Tab", + newTab: true + }, + { + href: (selectedRow): string => `/core/cdns/${selectedRow.id}` , + name: "Edit" + }, + { + action: "delete", + multiRow: false, + name: "Delete", + }, + { + action: "snapshot-diff", + multiRow: false, + name: "Diff Snapshot", + }, + { + action: "queue", + multiRow: false, + name: "Queue Server Updates" + }, + { + action: "dequeue", + multiRow: false, + name: "Clear Queued Updates" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/dnssec-keys` , + name: "Manage DNSSEC Keys" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/federations` , + name: "Manage Federations" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/delivery-services` , + name: "Manage Delivery Services" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/profiles?cdnName=${selectedRow.id}` , + name: "Manage Profiles" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/servers` , + name: "Manage Servers" + }, + { + disabled: (): true => true, + href: (selectedRow): string => `/core/cdns/${selectedRow.id}/notifications` , + name: "Manage Notifications" + }, + ]; + + /** + * A subject that child components can subscribe to for access to the fuzzy + * search query text. + */ + public fuzzySubject: BehaviorSubject<string>; + + /** Form controller for the user search input. */ + public fuzzControl: FormControl = new FormControl(""); + + constructor( + private readonly alerts: AlertService, + private readonly api: CDNService, + public readonly auth: CurrentUserService, + private readonly dialog: MatDialog, + private readonly route: ActivatedRoute, + ) { + this.fuzzySubject = new BehaviorSubject<string>(""); + this.cdns = this.api.getCDNs(); + } + + /** Initializes table data, loading it from Traffic Ops. */ + public ngOnInit(): void { + this.route.queryParamMap.subscribe( + m => { + const search = m.get("search"); + if (search) { + this.fuzzControl.setValue(decodeURIComponent(search)); + this.updateURL(); + } + } + ); + } + + /** Update the URL's 'search' query parameter for the user's search input. */ + public updateURL(): void { + this.fuzzySubject.next(this.fuzzControl.value); + } + + /** + * Queues or clears updates on a group of CDNs. + * + * @param cdn The CDN on which to queue updates. + * @param queue Whether updates should be queued (`true`) or cleared + * (`false`). + */ + private async queueUpdates(cdn: ResponseCDN, queue: boolean = true): Promise<void> { + const title = `${queue ? "Queue" : "Clear"} Updates on ${cdn.name}?`; + const action = queue ? "queue" : "dequeue"; + const ref = this.dialog.open<DecisionDialogComponent, DecisionDialogData, boolean>(DecisionDialogComponent, { + data: { + message: `Are you sure you want to ${action} server updates for all the ${cdn.name} servers?`, + title, + } + }); + if (!await ref.afterClosed().toPromise()) { + return; + } + await this.api.queueCDNUpdates(cdn, action); + this.alerts.newAlert( + AlertLevel.SUCCESS, + "Queued CDN server updates", + ); + } + + /** + * Asks the user for confirmation before deleting a CDN. + * + * @param cdn The CDN (potentially) being deleted. + */ + private async delete(cdn: ResponseCDN): Promise<void> { + const ref = this.dialog.open<DecisionDialogComponent, DecisionDialogData, boolean>(DecisionDialogComponent, { + data: { + message: `Are you sure you want to delete the ${cdn.name} CDN?`, + title: `Delete ${cdn.name}` + } + }); + if (await ref.afterClosed().toPromise()) { + await this.api.deleteCDN(cdn); + this.cdns = this.api.getCDNs(); + } + } + + /** + * Handles a context menu event. + * + * @param a The action selected from the context menu. + */ + public handleContextMenu(a: ContextMenuActionEvent<ResponseCDN>): void { + switch(a.action) { + case "queue": + this.queueUpdates(a.data as ResponseCDN); + break; + case "dequeue": + this.queueUpdates(a.data as ResponseCDN, false); Review Comment: Avoiding `as` in 2f6c6c9ea5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
