srijeet0406 commented on code in PR #7480:
URL: https://github.com/apache/trafficcontrol/pull/7480#discussion_r1191942465
##########
experimental/traffic-portal/src/app/api/testing/profile.service.ts:
##########
@@ -282,12 +282,12 @@ export class ProfileService {
public async createParameter(parameter: RequestParameter):
Promise<ResponseParameter> {
const t = {
...parameter,
- configFile: "cfg.txt",
+ configFile: parameter.configFile,
id: ++this.lastParamID,
lastUpdated: new Date(),
profiles: [],
- secure: false,
- value: "100"
+ secure: parameter.secure,
+ value: parameter.value ?? ""
};
Review Comment:
Thanks for explaining that. However, when I remove the `value` property, it
doesn't compile, possibly because of the types being different for the `value`
attribute in `RequestParameter` (string | null) vs `ResponseParameter`
(string). Any idea how to resolve that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
