rimashah25 commented on code in PR #7511:
URL: https://github.com/apache/trafficcontrol/pull/7511#discussion_r1192769059
##########
traffic_ops/traffic_ops_golang/login/register.go:
##########
@@ -263,7 +265,7 @@ func RegisterUser(w http.ResponseWriter, r *http.Request) {
Review Comment:
nit: extra new line?
##########
traffic_ops/traffic_ops_golang/login/register.go:
##########
@@ -287,13 +289,15 @@ func RegisterUser(w http.ResponseWriter, r *http.Request)
{
api.HandleErr(w, r, tx, errCode, userErr, sysErr)
return
}
-
+ if user.Username != nil {
Review Comment:
Shouldn't this check happen right after you check for error on L277?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
