Kashatlast2 commented on code in PR #7461:
URL: https://github.com/apache/trafficcontrol/pull/7461#discussion_r1192718333
##########
traffic_control/clients/python/trafficops/tosession.py:
##########
@@ -1361,6 +1361,17 @@ def get_physical_locations(self, query_params=None):
:raises: Union[LoginError, OperationError]
"""
+ @api_request('post', 'phys_locations', ('3.0', '4.0', '4.1', '5.0'))
Review Comment:
None of the other phys_locations functions have 3.1. Should I add it anyway?
##########
traffic_ops/testing/api_contract/v4/request_template.json:
##########
@@ -1,71 +1,75 @@
{
- "cdns": [
- {
- "name": "test",
- "domainName": "quest",
- "dnssecEnabled": false
- }
- ],
- "cachegroup": [
- {
- "name": "test",
- "shortName": "test",
- "latitude": 38.897663,
- "longitude": -77.036574,
- "fallbackToClosest": true,
- "localizationMethods": [
- "DEEP_CZ",
- "CZ",
- "GEO"
- ],
- "typeId": 23
- }
- ],
- "parameters": [
- {
- "name": "test",
- "value": "quest",
- "configFile": "records.config",
- "secure": false
- }
- ],
- "roles": [
- {
- "name": "test",
- "description": "quest"
- }
- ],
- "profiles": [
- {
- "name": "test",
- "description": "A test profile for API examples",
- "cdn": 2,
- "type": "UNK_PROFILE",
- "routingDisabled": true
- }
- ],
- "tenants": [
- {
- "active": true,
- "name": "test",
- "parentId": 1
- }
- ],
- "server_capabilities": [
- {
- "name": "RAM"
- }
- ],
- "divisions":[
- {
- "name":"test"
- }
- ],
- "regions": [
- {
+ "cdns": [
+ {
+ "name": "test",
+ "domainName": "quest",
+ "dnssecEnabled": false
+ }
+ ],
+ "cachegroup": [
+ {
+ "name": "test",
+ "shortName": "test",
+ "latitude": 38.897663,
+ "longitude": -77.036574,
+ "fallbackToClosest": true,
+ "localizationMethods": [
+ "DEEP_CZ",
+ "CZ",
+ "GEO"
+ ],
+ "typeId": 23
+ }
+ ],
+ "parameters": [
+ {
+ "name": "test",
+ "value": "quest",
+ "configFile": "records.config",
+ "secure": false
+ }
+ ],
+ "roles": [
+ {
+ "name": "test",
+ "description": "quest"
+ }
+ ],
+ "profiles": [
+ {
+ "name": "test",
+ "description": "A test profile for API examples",
+ "cdn": 2,
+ "type": "UNK_PROFILE",
+ "routingDisabled": true
+ }
+
+ ],
+ "divisions":[
+ {
+ "name":"test"
+ }
+ ],
+ "regions": [
+ {
"divisionName": "Quebec",
- "division": 1,
- "name": "Montreal"
- }
- ]
+ "division": 1,
+ "name": "Montreal"
+ }
+ ],
+ "phys_locations": [
+ {
+ "address": "Buckingham Palace",
+ "city": "London",
+ "comments": "Buckingham Palace",
+ "email": "[email protected]",
+ "name": "test",
+ "phone": "0-843-816-6276",
+ "poc": "Her Majesty The Queen Elizabeth Alexandra Mary
Windsor II",
+ "regionId": 3,
+ "shortName": "test",
+ "state": "Westminster",
+ "zip": "SW1A 1AA"
+ }
+ ]
Review Comment:
added them back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
