TerekhovaKate commented on code in PR #7523:
URL: https://github.com/apache/trafficcontrol/pull/7523#discussion_r1194356298


##########
traffic_ops/testing/api_contract/v4/conftest.py:
##########
@@ -845,39 +770,78 @@ def phys_locations_post_data(to_session: TOSession, 
request_template_data: list[
                if not isinstance(name, str):
                        raise TypeError(f"name must be str, not '{type(name)}'")
                phys_locations["name"] = name[:4] + randstr
-               shortName = phys_locations["shortName"]
+               shortname = phys_locations["shortName"]

Review Comment:
        shortName = phys_locations["shortName"]
        shortname = phys_locations["shortName"]
        please check name 
        short_name is recomended



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to