TerekhovaKate commented on code in PR #7529: URL: https://github.com/apache/trafficcontrol/pull/7529#discussion_r1198077709
########## traffic_ops/testing/api_contract/v4/test_delivery_services.py: ########## @@ -0,0 +1,84 @@ +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""API Contract Test Case for delivery services endpoint.""" +import logging +from typing import Union +import pytest +import requests +from jsonschema import validate + +from trafficops.tosession import TOSession + +# Create and configure logger +logger = logging.getLogger() + +Primitive = Union[bool, int, float, str, None] + + +def test_delivery_services_contract(to_session: TOSession, + response_template_data: dict[str, Union[Primitive, list[Union[Primitive, + dict[str, object], list[object]]], dict[object, object]]], + delivery_services_post_data: dict[str, object] +) -> None: + """ + Test step to validate keys, values and data types from delivery_services endpoint + response. + :param to_session: Fixture to get Traffic Ops session. + :param response_template_data: Fixture to get response template data from a prerequisites file. + :param delivery_services_post_data: Fixture to get sample delivery service data and response. + """ + # validate delivery services keys from api get response + logger.info("Accessing /delivery_services endpoint through Traffic ops session.") + + delivery_services_id = delivery_services_post_data["id"] + if not isinstance(delivery_services_id, int): + raise TypeError("malformed API response; 'id' property not a integer") + + delivery_services_get_response: tuple[ + Union[dict[str, object], list[Union[dict[str, object], list[object], Primitive]], Primitive], + requests.Response + ] = to_session.get_deliveryservices(query_params={"id": delivery_services_id}) + try: Review Comment: Redundant Try-Except Block: The try-except block around the deletion of the delivery_service appears to be unnecessary. It catches an IndexError that would never occur in that context. Consider removing the try-except block and handle the deletion separately if needed. first delivery_services in response is not an object as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
