zrhoffman commented on code in PR #7533:
URL: https://github.com/apache/trafficcontrol/pull/7533#discussion_r1199198805
##########
experimental/traffic-portal/server.ts:
##########
@@ -34,6 +34,14 @@ import {
import { AppServerModule } from "./src/main.server";
+const versionParts = process.versions.node.split(".");
+if (versionParts.length !== 3) {
+ console.warn(`Unable to determine current node version, got
${versionParts.length} items`);
+} else if (versionParts[0] < "16" || (versionParts[0] === "16" &&
versionParts[1] < "20")) {
+ console.error(`Unsupported version of node found: ${process.version},
expected >=16.20`);
+ process.exit(1);
+}
+
Review Comment:
I'd be okay with keeping it if the major and minor versions are derived,
rather than hard-coded here, so that it doesn't need to be updated when Node
gets upgraded. But since that doesn't block #7533 getting merged, that can go
in a separate patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
