srijeet0406 commented on code in PR #5613: URL: https://github.com/apache/trafficcontrol/pull/5613#discussion_r1201404659
########## CHANGELOG.md: ########## @@ -35,6 +35,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - [#7367](https://github.com/apache/trafficcontrol/pull/7367) *Traffic Ops* Adds ACME:CREATE, ACME:DELETE, ACME:DELETE, and ACME:READ permissions to operations role. - [#7380](https://github.com/apache/trafficcontrol/pull/7380) *Traffic Portal* Adds strikethrough (expired), red (7 days until expiration) and yellow (30 days until expiration) visuals to delivery service cert expiration grid rows. - [#7388](https://github.com/apache/trafficcontrol/pull/7388) *TC go Client* Adds sslkey_expiration methodology in v4 and v5 clients +- Added DNSSEC support to CDN in a Box and enabled it Review Comment: Could you please add the issue/ PR number and link? ########## infrastructure/cdn-in-a-box/traffic_ops_data/profiles/040-TRAFFIC_ROUTER.json: ########## @@ -10,6 +10,16 @@ "name": "monitor:///opt/tomcat/logs/access.log", "value": "index=index_odol_test;sourcetype=access_ccr" }, + { Review Comment: Both these params were removed in https://github.com/apache/trafficcontrol/pull/7109. You shouldn't need them anymore. ########## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/util/AbstractResourceWatcherTest.java: ########## @@ -115,7 +115,10 @@ public void testWatchers() { TrafficRouter trafficRouter = trafficRouterManager.getTrafficRouter(); CacheRegister cacheRegister = trafficRouter.getCacheRegister(); JsonNode config = cacheRegister.getConfig(); - assertNull(config.get(federationsWatcher.getWatcherConfigPrefix() + ".polling.url")); + JsonNode pollingUrlNode = config.get(federationsWatcher.getWatcherConfigPrefix() + ".polling.url"); + if (pollingUrlNode != null) { + assertThat(pollingUrlNode.asText(), not(endsWith("api/3.0/notAFederationsEndpoint"))); Review Comment: Should this be hardcoded to 3.0, or should we get the API version from TO_API_VERSION? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
