ocket8888 commented on code in PR #7562:
URL: https://github.com/apache/trafficcontrol/pull/7562#discussion_r1228643976
##########
experimental/traffic-portal/src/app/utils/index.spec.ts:
##########
@@ -99,7 +99,7 @@ describe("Typing utility functions", () => {
it("should check homogenous array types correctly", () => {
const a = {};
expect(isArray(a)).toBeFalse();
- const b = new Array();
+ const b: unknown[] = [];
Review Comment:
well it's technically incorrect. Before the change, b was `Array<never>`,
and after it's `Array<unknown>`. The way it's being used that doesn't matter,
but it does seem odd to me that they would add that "fixer".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
