jagan-parthiban commented on code in PR #7584:
URL: https://github.com/apache/trafficcontrol/pull/7584#discussion_r1237997706
##########
docs/Makefile:
##########
@@ -18,11 +18,21 @@
# under the License.
#
+ifeq ($(OS),Windows_NT)
+ T3C_DIR_SEP := \\
+ RM := del /s /q
+ PY := python
+else
+ T3C_DIR_SEP := /
+ RM := rm -rf
Review Comment:
I tried using the RM directly,
```
clean:
-RM $(BUILDDIR) $(T3C_RST_OUT)
```
But make clean will fail because RM defaults to `rm -f`. But we want to
delete directories and other files.
``` make clean ─╯
RM build source/admin/t3c//t3c-apply.rst
source/admin/t3c//t3c-check-refs.rst source/admin/t3c//t3c-check-reload.rst
source/admin/t3c//t3c-check.rst source/admin/t3c//t3c-diff.rst
source/admin/t3c//t3c-generate.rst source/admin/t3c//t3c-preprocess.rst
source/admin/t3c//t3c-request.rst source/admin/t3c//t3c-tail.rst
source/admin/t3c//t3c-update.rst source/admin/t3c//t3c.rst
source/admin/t3c//testing.rst
RM: build: is a directory
make: [clean] Error 1 (ignored)
````
Hence in earlier version, It was
```
clean:
-rm -rf $(BUILDDIR) $(T3C_RST_OUT)
```
And this worked fine with Mac/Linux but not windows. Hence we are using a if
else block to assign the variable appropriate meaning.
To avoid any conflict with in-build functionality i have now renamed the
variable from RM to REM.
```
ifeq ($(OS),Windows_NT)
T3C_DIR_SEP := \\
REM := del /s /q
PY := python
else
T3C_DIR_SEP := /
REM := rm -rf
PY := python3
endif
```
```
clean:
-$(REM) $(BUILDDIR) $(T3C_RST_OUT)
```
Now `make clean` will work in all environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
