traeak commented on code in PR #7580:
URL: https://github.com/apache/trafficcontrol/pull/7580#discussion_r1238576675
##########
cache-config/t3c-apply/t3c-apply.go:
##########
@@ -397,20 +398,27 @@ func CheckMaxmindUpdate(cfg config.Cfg) bool {
// Check if we have a URL for a maxmind db
// If we do, test if the file exists, do IMS based on disk time
// and download and unpack as needed
- result := false
+ retresult := false
if cfg.MaxMindLocation != "" {
// Check if the maxmind db needs to be updated before reload
- result = util.UpdateMaxmind(cfg)
- if result {
- log.Infoln("maxmind database was updated from " +
cfg.MaxMindLocation)
- } else {
- log.Infoln("maxmind database not updated. Either not
needed or curl/gunzip failure")
+ MaxMindList := strings.Split(cfg.MaxMindLocation, ",")
+ for _, v := range MaxMindList {
+ result := util.UpdateMaxmind(v, cfg.TsConfigDir,
cfg.ReportOnly)
+ if result {
+ log.Infoln("maxmind database was updated from "
+ v)
+ } else {
+ log.Infoln("maxmind database not updated.
Either not needed or curl/gunzip failure")
Review Comment:
If this fails is the failing maxmind DB identified? Perhaps add to the
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
