ocket8888 opened a new pull request, #7599:
URL: https://github.com/apache/trafficcontrol/pull/7599
What this PR is primarily meant to do is make keeping parity between API
services and their mock testing services easier for developers. It does this
by, for each API service, ensuring it is `implement`ed by the corresponding
mock/testing service. For example, with the API service:
```typescript
export class FooService extends APIService {
//...
}
```
in `experimental/traffic-portal/src/app/api`, this PR ensures there is a
corresponding service in `experimental/traffic-portal/src/app/api/testing` such
that:
```typescript
import { FooService as ConcreteFooService } from "../foo.service.ts";
export class FooService implements ConcreteFooService {
//...
}
```
This means that adding functionality to the "concrete" service that isn't
being properly mocked will result in testing compilation errors.
In order to ensure the services are working properly, this PR also adds 100%
test coverage to `experimental/traffic-portal/src/app/api/testing` and fills
any gaps in testing coverage for `experimental/traffic-portal/src/app/api`.
<hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Portal (experimental v2)
## What is the best way to verify this PR?
Make sure the provided tests pass.
## PR submission checklist
- [x] This PR has tests
- [x] This PR doesn't need documentation
- [x] This PR doesn't need a CHANGELOG.md entry
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
