shamrickus commented on code in PR #7585:
URL: https://github.com/apache/trafficcontrol/pull/7585#discussion_r1242697101
##########
experimental/traffic-portal/src/environments/environment.prod.ts:
##########
@@ -21,5 +21,6 @@ import type { Environment } from "./environment.type";
export const environment: Environment = {
apiVersion: "4.0",
customModule: false,
- production: true
+ production: true,
+ tpv1Url: "https://tp.staging.cdnlab.comcast.net/#!";,
Review Comment:
You shouldn't link this to any actual environments, especially any comcast
internal ones. I'd have the default point to one of the CiaB instances. Either
`localhost:444` or `localhost:443`
##########
experimental/traffic-portal/src/environments/environment.ts:
##########
@@ -26,5 +26,6 @@ export const environment: Environment = {
apiVersion: "4.0",
customModule: false,
production: false,
- useExhaustiveDates: true
+ tpv1Url: "https://tp.staging.cdnlab.comcast.net/#!";,
Review Comment:
This file is a _compile_ time configuration setting. We need this redirect
to be a _runtime_ configuration setting since the link should be able to change
on the fly. This should probably go in the config file read from `server.ts`,
and passed to the app through `TransferState` using ng universal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
