jhg03a commented on code in PR #7625:
URL: https://github.com/apache/trafficcontrol/pull/7625#discussion_r1258748453
##########
infrastructure/ansible/roles/traffic_ops/tasks/traffic_ops.yml:
##########
@@ -122,6 +122,12 @@
dest: "{{ to_tvdb_aes_key_loc }}"
notify: Restart Traffic Ops
+- name: Remove LDAP config if LDAP not used
+ file:
+ path: "{{ to_conf_installdir }}/ldap.conf"
+ state: absent
+ when: to_ldap_setup == "no"
Review Comment:
This needs to use actual boolean evaluation instead of string matching
##########
infrastructure/ansible/roles/traffic_ops/tasks/traffic_ops.yml:
##########
@@ -134,10 +140,19 @@
- production/log4perl.conf
- production/riak.conf
- cdn.conf
- - ldap.conf
- influxdb.conf
notify: Restart Traffic Ops
+- name: Render Traffic Ops LDAP configuration file
+ template:
+ src: "ldap.conf.j2"
+ owner: "{{ to_user }}"
+ group: "{{ to_group }}"
+ mode: 0600
+ dest: "{{ to_conf_installdir }}/ldap.conf"
+ notify: Restart Traffic Ops
+ when: to_ldap_setup == "yes"
Review Comment:
This needs to use actual boolean evaluation instead of string matching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
