srijeet0406 commented on code in PR #7596:
URL: https://github.com/apache/trafficcontrol/pull/7596#discussion_r1259987968
##########
traffic_ops/traffic_ops_golang/federation_resolvers/federation_resolvers.go:
##########
@@ -174,7 +175,21 @@ func Read(w http.ResponseWriter, r *http.Request) {
return
}
- resolvers = append(resolvers, resolver)
+ // Based on version we load types - for version 5 and above we
use FederationResolverV5
+ if inf.Version.GreaterThanOrEqualTo(&api.Version{Major: 5,
Minor: 0}) {
+ var v5Resolver tc.FederationResolverV5
+
+ // Convert FederationResolver fields to
FederationResolverV5 fields
+ v5Resolver.ID = resolver.ID
Review Comment:
This looks good. Do you mind making it into a utility function please, so
that future development can make use of it and not have to repeat these lines
everywhere?
##########
traffic_ops/traffic_ops_golang/federation_resolvers/federation_resolvers.go:
##########
@@ -174,7 +175,21 @@ func Read(w http.ResponseWriter, r *http.Request) {
return
}
- resolvers = append(resolvers, resolver)
+ // Based on version we load types - for version 5 and above we
use FederationResolverV5
+ if inf.Version.GreaterThanOrEqualTo(&api.Version{Major: 5,
Minor: 0}) {
+ var v5Resolver tc.FederationResolverV5
+
+ // Convert FederationResolver fields to
FederationResolverV5 fields
+ v5Resolver.ID = resolver.ID
+ v5Resolver.IPAddress = resolver.IPAddress
+ lastUpdated := time.Unix(resolver.LastUpdated.Unix(), 0)
+ v5Resolver.LastUpdated = &lastUpdated
+ v5Resolver.Type = resolver.Type
+
+ resolvers = append(resolvers, &v5Resolver)
Review Comment:
Should this be appending the reference of v5Resolver?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
