cybertunnel opened a new pull request, #7639: URL: https://github.com/apache/trafficcontrol/pull/7639
<!-- Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md If this closes or relates to an existing issue, please reference it using one of the following: If this PR fixes a security vulnerability, DO NOT submit! Instead, contact the Apache Traffic Control Security Team at [email protected] and follow the guidelines at https://apache.org/security regarding vulnerability disclosure. --> Closes: #7638 This PR is to fix an issue where as in #7638, the `strategies.yaml` does not include a `parent_is_proxy` value for any servers in the file. This PR also fixes an issue from tech debt where the `strategiesdotconfig.go` is supposed to be `strategiesdotyaml.go` since the file changed from `.config` to `.yaml` <!-- **^ Add meaningful description above** --><hr/> ## Which Traffic Control components are affected by this PR? <!-- Please delete all components from this list that are NOT affected by this PR. Feel free to add the name of a tool or script that is affected but not on the list. --> - Traffic Control Cache Config (`t3c`, formerly ORT) ## What is the best way to verify this PR? <!-- Please include here ALL the steps necessary to test your PR. If your PR has tests (and most should), provide the steps needed to run the tests. If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. --> I have added a test in `strategiesdotyaml_tests.go`, the function is `TestMakeStrategiesDotYAMLParentIsProxy` which tests when `opt.ParentIsProxy` is set to `true` and when it is set to `false`. ## If this is a bugfix, which Traffic Control versions contained the bug? <!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch. Examples: - 5.1.2 - 5.1.3 (RC1) --> I would imagine all existing versions have this issue since switching to `.yaml` structure. ## PR submission checklist - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. --> - [ ] This PR has documentation - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) This PR doesn't need documentation since it has everything already documented in ATS's page. This is just fixing a behavior we were expecting. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
