ocket8888 commented on code in PR #7660:
URL: https://github.com/apache/trafficcontrol/pull/7660#discussion_r1275108892
##########
lib/go-tc/deliveryservice_servers.go:
##########
@@ -168,6 +168,47 @@ type DSServerBaseV4 struct {
DeliveryServiceCapabilities []string `json:"-"
db:"deliveryservice_capabilities"`
}
+// DSServerBaseV5 contains the base information for a Delivery Service Server
associated with APIv5.
+type DSServerBaseV5 = DSServerBaseV50
+
+// DSServerBaseV50 contains the base information for a Delivery Service Server
for the latest major version associated with APIv50.
+type DSServerBaseV50 struct {
Review Comment:
The reason we have a `DSServerBase` was to re-use a struct that shares many
details between v4 and earlier versions. You are only using DSServerBaseV50 in
exactly one place: the definition of DSServerV50. So it's completely
unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
