jhg03a commented on code in PR #7665:
URL: https://github.com/apache/trafficcontrol/pull/7665#discussion_r1279734882
##########
infrastructure/ansible/roles/dataset_loader/defaults/main.yml:
##########
@@ -813,6 +815,19 @@ dl_ds_default_profile_layers:
- name: CONFIG proxy.config.ssl.server.multicert.exit_on_load_fail
configFile: records.config
value: INT 0
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.http.origin_max_connections
+ configFile: records.config
+ value: INT 500
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.cache.http.compatibility.4-2-0-fixup
+ configFile: records.config
+ value: INT 0
Review Comment:
This is not specific to ATS 7, but rather ATS 7 & 8. I'm not a huge fan of
duplicating this param, but its probably more messy to add new combinatorial
variable levels.
##########
infrastructure/ansible/roles/dataset_loader/defaults/main.yml:
##########
@@ -805,6 +799,14 @@ dl_ds_default_profile_layers:
- name: remap_stats.so
configFile: plugin.config
value: ''
+ # ATS 7 specific param
+ - name: CONFIG proxy.config.http.origin_max_connections
+ configFile: records.config
+ value: INT 500
+ # ATS 7 specific param
+ - name: CONFIG proxy.config.cache.http.compatibility.4-2-0-fixup
+ configFile: records.config
+ value: INT 0
Review Comment:
This is not specific to ATS 7, but rather ATS 7 & 8. I'm not a huge fan of
duplicating this param, but its probably more messy to add new combinatorial
variable levels.
##########
infrastructure/ansible/roles/dataset_loader/defaults/main.yml:
##########
@@ -858,7 +870,20 @@ dl_ds_default_profile_layers:
- name: CONFIG proxy.config.cop.active_health_checks
configFile: records.config
value: INT 0
- v8: []
+ # ATS 7 specific param
+ - name: CONFIG proxy.config.http.origin_max_connections
+ configFile: records.config
+ value: INT 1500
+ v8:
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.http.origin_max_connections
+ configFile: records.config
+ value: INT 1500
Review Comment:
This is not specific to ATS 7, but rather ATS 7 & 8. I'm not a huge fan of
duplicating this param, but its probably more messy to add new combinatorial
variable levels.
##########
infrastructure/ansible/roles/dataset_loader/defaults/main.yml:
##########
@@ -1216,6 +1232,18 @@ dl_ds_default_profile_layers:
- name: CONFIG proxy.config.http.normalize_ae_gzip
configFile: records.config
value: INT 0
+ # ATS 7 specific param
+ - name: CONFIG proxy.config.net.max_connections_active_in
+ configFile: records.config
+ value: INT 100000
+ # ATS 7 specific param
+ - name: CONFIG proxy.config.http.origin_max_connections_queue
+ configFile: records.config
+ value: INT 0
+ # ATS 7 specific param
+ - name: CONFIG proxy.config.http.parent_proxy_routing_enable
+ configFile: records.config
+ value: INT 1
Review Comment:
This is not specific to ATS 7, but rather ATS 7 & 8. I'm not a huge fan of
duplicating this param, but its probably more messy to add new combinatorial
variable levels.
##########
infrastructure/ansible/roles/dataset_loader/defaults/main.yml:
##########
@@ -1297,6 +1325,39 @@ dl_ds_default_profile_layers:
- name: LOCAL proxy.local.cluster.type
configFile: records.config
value: INT 3
+ # Param value changed between ATS 7 & 8
+ - name: CONFIG proxy.config.net.sock_option_flag_in
+ configFile: records.config
+ value: INT 5
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.net.max_connections_active_in
Review Comment:
This is not specific to ATS 7, but rather ATS 7 & 8. I'm not a huge fan of
duplicating this param, but its probably more messy to add new combinatorial
variable levels.
##########
infrastructure/ansible/roles/dataset_loader/defaults/main.yml:
##########
@@ -1297,6 +1325,39 @@ dl_ds_default_profile_layers:
- name: LOCAL proxy.local.cluster.type
configFile: records.config
value: INT 3
+ # Param value changed between ATS 7 & 8
+ - name: CONFIG proxy.config.net.sock_option_flag_in
+ configFile: records.config
+ value: INT 5
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.net.max_connections_active_in
+ configFile: records.config
+ value: INT 100000
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.http.origin_max_connections_queue
+ configFile: records.config
+ value: INT 0
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.http.parent_proxy_routing_enable
+ configFile: records.config
+ value: INT 1
+ v9:
+ # Param change for ATS 9, from
proxy.config.net.max_connections_active_in
+ - name: CONFIG proxy.config.net.max_requests_in
+ configFile: records.config
+ value: INT 100000
+ # Param change for ATS 9, from
proxy.config.http.origin_max_connections_queue
+ - name: CONFIG proxy.config.http.per_server.connection.queue_size
+ configFile: records.config
+ value: INT 0
+ # Param value changed between ATS 7,9
+ - name: CONFIG proxy.config.net.sock_option_flag_in
+ configFile: records.config
+ value: INT 1
Review Comment:
This is still modeled in the common/common set with a different value. This
one might be a mistake?
##########
infrastructure/ansible/roles/dataset_loader/defaults/main.yml:
##########
@@ -1297,6 +1325,39 @@ dl_ds_default_profile_layers:
- name: LOCAL proxy.local.cluster.type
configFile: records.config
value: INT 3
+ # Param value changed between ATS 7 & 8
+ - name: CONFIG proxy.config.net.sock_option_flag_in
+ configFile: records.config
+ value: INT 5
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.net.max_connections_active_in
+ configFile: records.config
+ value: INT 100000
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.http.origin_max_connections_queue
+ configFile: records.config
+ value: INT 0
+ # ATS 8 specific param
+ - name: CONFIG proxy.config.http.parent_proxy_routing_enable
+ configFile: records.config
+ value: INT 1
+ v9:
+ # Param change for ATS 9, from
proxy.config.net.max_connections_active_in
+ - name: CONFIG proxy.config.net.max_requests_in
+ configFile: records.config
+ value: INT 100000
+ # Param change for ATS 9, from
proxy.config.http.origin_max_connections_queue
+ - name: CONFIG proxy.config.http.per_server.connection.queue_size
+ configFile: records.config
+ value: INT 0
+ # Param value changed between ATS 7,9
+ - name: CONFIG proxy.config.net.sock_option_flag_in
+ configFile: records.config
+ value: INT 1
+ # Param value changed between ATS 8 & 9, default is 0
+ - name: CONFIG proxy.config.ssl.handshake_timeout_in
+ configFile: records.config
+ value: INT 30
Review Comment:
Is this to say that the default changed between 8 & 9 and we're preserving
the older value of 30 in ATS 9?
##########
infrastructure/ansible/roles/dataset_loader/defaults/main.yml:
##########
@@ -1297,6 +1325,39 @@ dl_ds_default_profile_layers:
- name: LOCAL proxy.local.cluster.type
configFile: records.config
value: INT 3
+ # Param value changed between ATS 7 & 8
+ - name: CONFIG proxy.config.net.sock_option_flag_in
+ configFile: records.config
+ value: INT 5
Review Comment:
This is still modeled in the common/common set with a different value. This
one might be a mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
