ocket8888 commented on PR #7718: URL: https://github.com/apache/trafficcontrol/pull/7718#issuecomment-1693804008
> > > You resolved [this conversation](https://github.com/apache/trafficcontrol/pull/7718#discussion_r1302074955) but went ahead and did it anyway? Please revert the Version changes not directly related to this PR. If you still think those changes are worthwhile, you can open a separate PR with those changes. > > > > > > I... don't know what you mean? I resolved the conversation **because** I made changes which I believed resolved the conversation. You requested I do something, not that I not do anything? > > From the commit message of [324fe57](https://github.com/apache/trafficcontrol/commit/324fe57b9b2ea01cde4db72c069fe9b0390c6cd5) > > > Also simplified those methods to just GreaterThan, LessThan and Equal, and removed unnecessary pointer recievers and arguments (all can just be pass-by-value). > > That is what I was pushing back against in [#7718 (comment)](https://github.com/apache/trafficcontrol/pull/7718#discussion_r1302074955) (and just now in [#7718 (comment)](https://github.com/apache/trafficcontrol/pull/7718#discussion_r1304603210)). Well, sure, but that was after I already made the changes and resolved the conversation. So I'm confused how you could think I "went ahead and did it anyway", since when I did it there couldn't have been any objections yet to that which hadn't been done. > That part has no place in #7718, it messes with a bunch of stuff totally unrelated to using RFC 3339 timestamps for servers. Fair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
