ocket8888 commented on code in PR #7733:
URL: https://github.com/apache/trafficcontrol/pull/7733#discussion_r1311792768
##########
traffic_ops/testing/api/v5/origins_test.go:
##########
@@ -277,17 +277,18 @@ func TestOrigins(t *testing.T) {
"OK when VALID request": {
EndpointID: GetOriginID(t,
"origin2"),
ClientSession: TOSession,
- RequestBody: tc.Origin{
- Name:
util.Ptr("origin2"),
- Cachegroup:
util.Ptr("multiOriginCachegroup"),
- Coordinate:
util.Ptr("coordinate2"),
- DeliveryService:
util.Ptr("ds3"),
- FQDN:
util.Ptr("originupdated.example.com"),
- IPAddress:
util.Ptr("1.2.3.4"),
- IP6Address:
util.Ptr("0000::1111"),
- Port: util.Ptr(1234),
- Protocol:
util.Ptr("http"),
- TenantID:
util.Ptr(GetTenantID(t, "tenant2")()),
+ RequestBody: tc.OriginV5{
+ Name: "origin2",
+ Cachegroup:
util.Ptr("multiOriginCachegroup"),
+ Coordinate:
util.Ptr("coordinate2"),
+ DeliveryService: "ds3",
+ DeliveryServiceID:
GetDeliveryServiceId(t, "ds3")(),
Review Comment:
You shouldn't need to add this line. It shouldn't need to manually fetch the
TenantID, either, but it was already doing that before you touched this file,
so that's not your problem.
##########
traffic_ops/testing/api/v5/origins_test.go:
##########
@@ -646,18 +649,20 @@ func DeleteTestOrigins(t *testing.T) {
assert.NoError(t, err, "Cannot get Origins : %v - alerts: %+v", err,
origins.Alerts)
for _, origin := range origins.Response {
+ origin.TenantID = GetTenantID(t, "root")()
+ origin.DeliveryServiceID = GetDeliveryServiceId(t,
origin.DeliveryService)()
Review Comment:
This should not be necessary because of the changes you made in the client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
