ocket8888 commented on code in PR #7790:
URL: https://github.com/apache/trafficcontrol/pull/7790#discussion_r1319132275
##########
traffic_ops/app/db/seeds.sql:
##########
@@ -209,10 +187,10 @@ INSERT INTO public.role_capability
SELECT id, perm
FROM public.role
CROSS JOIN ( VALUES
- ('ACME:CREATE'),
- ('ACME:DELETE'),
- ('ACME:READ'),
- ('ACME:UPDATE'),
+ ('ACME:CREATE'),
+ ('ACME:DELETE'),
+ ('ACME:READ'),
+ ('ACME:UPDATE'),
Review Comment:
accidentally using spaces instead of indentation
##########
traffic_ops/app/db/seeds.sql:
##########
@@ -236,6 +214,7 @@ CROSS JOIN ( VALUES
('DIVISION:UPDATE'),
('DNS-SEC:READ'),
('DNS-SEC:UPDATE'),
+ ('DNS-SEC:DELETE')
Review Comment:
Missing comma, which is why the tests failed.
Also you're using spaces instead of indentation
##########
traffic_ops/app/db/seeds.sql:
##########
@@ -136,6 +113,7 @@ CROSS JOIN ( VALUES
('CDNI-CAPACITY:READ'),
('COORDINATE:READ'),
('DELIVERY-SERVICE:READ'),
+ ('DELIVERY-SERVICE-SAFE:UPDATE'),
Review Comment:
same as above RE: indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
