TerekhovaKate commented on code in PR #7788: URL: https://github.com/apache/trafficcontrol/pull/7788#discussion_r1320038679
########## traffic_ops/testing/api_contract/v4/test_logs.py: ########## @@ -0,0 +1,84 @@ +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +API Contract Test Case for logs endpoint. +""" + +import logging +from typing import Union +import pytest +import requests +from jsonschema import validate +from trafficops.tosession import TOSession + +# Create and configure logger +logger = logging.getLogger() + +Primitive = Union[bool, int, float, str, None] + + +def test_logs_contract( + to_session: TOSession, + response_template_data: dict[str, Union[Primitive, list[Union[Primitive, dict[str, object], + list[object]]], dict[object, object]]], logs_data: list[Union[int, dict[str, object]]]) -> None: + """ + Test step to validate keys, values, and data types from logs endpoint response. + :param to_session: Fixture to get Traffic Ops session. + :param response_template_data: Fixture to get response template data from prerequisites file. + """ + # Validate Log keys from logs get response + logger.info("Accessing /logs endpoint through Traffic ops session.") + + for log in logs_data: + if isinstance(log, dict): + change_log_id = log.get("id") + if not isinstance(change_log_id, int): + raise TypeError("Malformed log in prerequisite data; 'id' not an integer") + + # Hitting logs GET response + change_logs_get_response: tuple[JSONData, requests.Response] = to_session.get_change_logs() + + logs_data, _ = change_logs_get_response Review Comment: check the variable declaration... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
