zrhoffman commented on code in PR #7795:
URL: https://github.com/apache/trafficcontrol/pull/7795#discussion_r1323266335
##########
infrastructure/cdn-in-a-box/enroller/enroller.go:
##########
@@ -318,10 +318,10 @@ func enrollDeliveryServiceServer(toSession *session, r
io.Reader) error {
if len(servers.Response) == 0 {
return errors.New("no server with hostName " + sn)
}
- if servers.Response[0].ID == nil {
- return fmt.Errorf("Traffic Ops gave back a
representation for server '%s' with null or undefined ID", sn)
+ if servers.Response[0].ID < 1 {
+ return fmt.Errorf("Traffic Ops gave back a
representation for server '%s' with non-positive ID", sn)
Review Comment:
> I think you should just get rid of this check instead of "fixing" it.
Removed in 6268f0aa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
