jpappa200 commented on code in PR #7774:
URL: https://github.com/apache/trafficcontrol/pull/7774#discussion_r1324583677
##########
lib/go-atscfg/remapdotconfig.go:
##########
@@ -984,24 +984,24 @@ func remapFilterDSes(server *Server, dss
[]DeliveryServiceServer, dses []Deliver
if ds.LastHeaderRewrite == nil {
ds.LastHeaderRewrite = util.StrPtr("")
}
- if ds.XMLID == nil {
+ if &ds.XMLID == nil {
Review Comment:
changed
##########
lib/go-atscfg/remapdotconfig.go:
##########
@@ -984,24 +984,24 @@ func remapFilterDSes(server *Server, dss
[]DeliveryServiceServer, dses []Deliver
if ds.LastHeaderRewrite == nil {
ds.LastHeaderRewrite = util.StrPtr("")
}
- if ds.XMLID == nil {
+ if &ds.XMLID == nil {
warnings = append(warnings, "got Delivery Service with
nil XMLID, skipping!")
continue
} else if ds.Type == nil {
- warnings = append(warnings, "got Delivery Service
'"+*ds.XMLID+"' with nil Type, skipping!")
+ warnings = append(warnings, "got Delivery Service
'"+ds.XMLID+"' with nil Type, skipping!")
continue
- } else if ds.DSCP == nil {
- warnings = append(warnings, "got Delivery Service
'"+*ds.XMLID+"' with nil DSCP, skipping!")
+ } else if &ds.DSCP == nil {
+ warnings = append(warnings, "got Delivery Service
'"+ds.XMLID+"' with nil DSCP, skipping!")
continue
} else if ds.ID == nil {
- warnings = append(warnings, "got Delivery Service
'"+*ds.XMLID+"' with nil ID, skipping!")
+ warnings = append(warnings, "got Delivery Service
'"+ds.XMLID+"' with nil ID, skipping!")
continue
- } else if ds.Active == nil {
- warnings = append(warnings, "got Delivery Service
'"+*ds.XMLID+"' with nil Active, skipping!")
+ } else if &ds.Active == nil {
+ warnings = append(warnings, "got Delivery Service
'"+ds.XMLID+"' with nil Active, skipping!")
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
