zrhoffman opened a new pull request, #7814: URL: https://github.com/apache/trafficcontrol/pull/7814
<!-- Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md If this closes or relates to an existing issue, please reference it using one of the following: Closes: #ISSUE Related: #ISSUE If this PR fixes a security vulnerability, DO NOT submit! Instead, contact the Apache Traffic Control Security Team at [email protected] and follow the guidelines at https://apache.org/security regarding vulnerability disclosure. --> This PR fixes #4380 and fixes #6304 by updating the ATC module path from https://github.com/apache/trafficcontrol/blob/75c37693f80bc774ca175a8720d418d983bc4ea3/go.mod#L1 to https://github.com/apache/trafficcontrol/blob/1872785c5354ae1055a67cfe59f0cf57bdeffab6/go.mod#L1 and updates references to the latest ATC Go module around the repo to reference the `v8` version. See the git history for the commands used to update files and https://github.com/apache/trafficcontrol/issues/4380#issuecomment-947812818 for the motivation for this PR. Note that this PR does *not* move any files. Once this PR is merged, a message will appear at the top of https://pkg.go.dev/github.com/apache/trafficcontrol lik this:  because the latest module will be at https://pkg.go.dev/github.com/apache/trafficcontrol/v8. <!-- **^ Add meaningful description above** --><hr/> ## Which Traffic Control components are affected by this PR? <!-- Please delete all components from this list that are NOT affected by this PR. Feel free to add the name of a tool or script that is affected but not on the list. --> - Documentation - Traffic Control Cache Config (T3C, formerly ORT) - Traffic Control Health Client (tc-health-client) - Traffic Control Client <!-- Please specify which (Python, Go, or Java) --> - Traffic Monitor - Traffic Ops - Traffic Stats - Grove - CDN in a Box (Enroller) ## What is the best way to verify this PR? <!-- Please include here ALL the steps necessary to test your PR. If your PR has tests (and most should), provide the steps needed to run the tests. If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. --> Verify that the 8 non-URL, non-local-path instances of `github.com/apache/trafficcontrol/` in the repo that did not have `v8/` appended to them. They should stay as-is: ``` repo=github.com/apache/trafficcontrol/ git ls-files | xargs grep -Fn "$repo" 2>/dev/null | grep -vE "(https://|src/)${repo//./\\.}" | grep -vF "${repo}v8" blueprints/api.guidelines.md:101:[the ATC library's Alert structure](https://pkg.go.dev/github.com/apache/trafficcontrol/lib/go-tc#Alert). blueprints/refetch-invalidation.md:291:github.com/apache/trafficcontrol/lib/go-atscfg/regexrevalidatedotconfig_test.go blueprints/refetch-invalidation.md:298:github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/invalidationjobs/invalidationjobs.go blueprints/refetch-invalidation.md:304:github.com/apache/trafficcontrol/traffic_ops/testing/api/v1/jobs_test.go blueprints/refetch-invalidation.md:305:github.com/apache/trafficcontrol/traffic_ops/testing/api/v2/jobs_test.go blueprints/refetch-invalidation.md:306:github.com/apache/trafficcontrol/traffic_ops/testing/api/v3/jobs_test.go blueprints/refetch-invalidation.md:307:github.com/apache/trafficcontrol/traffic_ops/testing/api/v4/jobs_test.go CHANGELOG.md:694:- Importing Traffic Ops Go clients via the un-versioned `github.com/apache/trafficcontrol/traffic_ops/client` is now deprecated in favor of versioned import paths e.g. `github.com/apache/trafficcontrol/traffic_ops/v3-client`. ``` ## PR submission checklist - [x] Existing tests are sufficient <!-- If not, please delete this text and explain why this PR does not need tests. --> - [x] Modified existing documentation <!-- If not, please delete this text and explain why this PR does not need documentation. --> - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. --> - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
