ntheanh201 commented on PR #7881: URL: https://github.com/apache/trafficcontrol/pull/7881#issuecomment-1841911516
> I'm assuming you opened this PR to look for feedback, even though it's still a draft. I realize parts of it aren't ready for that yet, but I commented on them a couple times anyway, just in case. The table controller looks _mostly_ good, although I haven't compared it to the functionality of the TPv1 counterpart. Obviously testing needs a lot of work. I'm gonna try to work on migrating our tests to cypress over the holidays, which will hopefully make the e2e testing easier. Yeah, I made it in draft because it's not ready for review yet. But thanks for your review, I'll check it. The code is copied from some other components and some parts I didn't change it ^^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
