rimashah25 commented on code in PR #7885:
URL: https://github.com/apache/trafficcontrol/pull/7885#discussion_r1430708980
##########
traffic_ops/traffic_ops_golang/profile/profiles.go:
##########
@@ -439,9 +439,9 @@ func Read(w http.ResponseWriter, r *http.Request) {
profileInterfaces := []interface{}{}
for _, p := range profileList {
- // Attach Parameters if the 'param' parameter is sent
- if _, ok := inf.Params["param"]; ok {
- p.Parameters, err = ReadParameters(inf.Tx, inf.User,
p.ID, inf.User.Can("PARAMETER-SECURE:READ"))
+ // Attach Parameters if the 'id' parameter is sent
+ if _, ok := inf.Params["id"]; ok {
+ p.Parameters, err = ReadParameters(inf.Tx, inf.User,
p.ID, inf.User.Can("PARAMETER:SECURE-READ"))
Review Comment:
no, this was an incorrect check originally which wasn't listsing the params
associated with a profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
