ericholguin commented on code in PR #5613:
URL: https://github.com/apache/trafficcontrol/pull/5613#discussion_r1498135622


##########
infrastructure/cdn-in-a-box/traffic_ops/trafficops-init.sh:
##########
@@ -71,6 +71,21 @@ delayfor() {
     local d="${f%/*}"
 
     case $d in
+        deliveryservices)
+            local cdns_json
+            cdns_json="$(to-get "api/${TO_API_VERSION}/cdns?name=${CDN_NAME}")"
+            if [[ "$(<<<"$cdns_json" jq '.response[].dnssecEnabled')" == false 
]]; then
+              echo "DNSSEC is not enabled for ${CDN_FQDN}"
+              return
+            fi
+            jq_filter='.date = $date | .key = $cdn_name | .name = $domain | 
.ttl = 60 | .kskExpirationDays = 365 | .zskExpirationDays = 30'
+            generate_dnssec_body="$(jq -n --arg cdn_name "$CDN_NAME" --arg 
domain "$CDN_FQDN" --arg date "$(date --rfc-3339=seconds)" "$jq_filter")"

Review Comment:
   Is this body missing the `dnssecEnabled` field? Won't it default to false? 
After building CiaB i'm still seeing it as false, wondering if its cause of 
this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to