ocket8888 commented on code in PR #7927:
URL: https://github.com/apache/trafficcontrol/pull/7927#discussion_r1506279362
##########
traffic_stats/build/build_rpm.sh:
##########
@@ -78,6 +78,19 @@ initBuildArea() {
go build -v -gcflags "$gcflags" -ldflags "$ldflags"
create/create_ts_databases.go || \
{ echo "Could
not build create_ts_databases binary"; return 1; })
+ # compile trafficcontrol-scenes
+ echo "Installing grafana scenes npm dependencies"
+ (cd trafficcontrol-scenes
+ npm i || \
Review Comment:
my build fails on this line with
```
----- Building traffic_stats ...
/usr/bin/realpath
git is /usr/bin/git
go is /usr/bin/go
/tmp/go/src/github.com/apache/trafficcontrol/build/functions.sh: line 182:
type: npm: not found
npm not found in PATH
Error on line 1 of traffic_stats/build/build_rpm.sh
traffic_stats failed: traffic_stats/build/build_rpm.sh
The following subdirectories had errors:
traffic_stats
Error on line 1 of ./build/build.sh
```
I rebuilt the builder to be sure. Command I used to test was `./pkg -v -L -S
traffic_stats_build`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
