smalenfant commented on code in PR #7861:
URL: https://github.com/apache/trafficcontrol/pull/7861#discussion_r1519653613
##########
cache-config/t3c-apply/config/config.go:
##########
@@ -681,8 +681,7 @@ func getOSSvcManagement() SvcManagement {
_svcManager = SystemD
} else if isCommandAvailable(Service) {
_svcManager = SystemV
- }
- if !isCommandAvailable(Chkconfig) {
+ } else {
Review Comment:
Centos/Rocky 7,8 and 9 support chkconfig. Just depends if it's installed or
not. That's the wrong way to detect which service manager is installed. This is
really up to the software used (ATS) and how it's been packaged. I think we
should remove these checks entirely as they seem invalid and just use systemctl
by default.
Using systemctl for SystemV type works anyway. By removing, we just don't
support Centos 6 anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
