jagan-parthiban commented on code in PR #8013:
URL: https://github.com/apache/trafficcontrol/pull/8013#discussion_r1621986763
##########
traffic_ops/traffic_ops_golang/login/login.go:
##########
@@ -171,18 +183,27 @@ func LoginHandler(db *sqlx.DB, cfg config.Config)
http.HandlerFunc {
// Attempt to perform client certificate authentication. If
fails, goto standard form auth. If the
// certificate was verified, has a UID, and the UID matches an
existing user we consider this to
// be a successful login.
- authenticated = clientCertAuthentication(w, r, db, cfg, dbCtx,
cancelTx, &form, authenticated)
+ triedAuthentication, authenticated =
clientCertAuthentication(w, r, db, cfg, dbCtx, cancelTx, &form, authenticated)
+
+ // skipped certificate-based auth, log and continue
+ if !triedAuthentication {
+ log.Infof("skipped certificate-based auth because
either no certs provided by the client or no configuration is set")
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
