zrhoffman commented on code in PR #7958:
URL: https://github.com/apache/trafficcontrol/pull/7958#discussion_r1625357715
##########
traffic_server/_tsb/run.sh:
##########
@@ -73,4 +73,4 @@ ED
# This includes changing output redirection to traffic.out and adding
udev-settle to wait for disks
(sed -i 's/ExecStart=@exp_bindir@\/traffic_manager
\$TM_DAEMON_ARGS/ExecStart=@exp_bindir@\/traffic_manager --bind_stdout
@exp_logdir@\/traffic.out --bind_stderr @exp_logdir@\/traffic.out
\$TM_DAEMON_ARGS/g' /rpmbuilddir/SOURCES/src/rc/trafficserver.service.in)
(sed -i 's/After=syslog.target
network.target/Wants=systemd-udev-settle.service \nAfter=syslog.target
network.target systemd-udev-settle.service/g'
/rpmbuilddir/SOURCES/src/rc/trafficserver.service.in)
-rpmbuild -bb ${rpmbuild_openssl} --define "_topdir /rpmbuilddir"
/rpmbuilddir/SPECS/trafficserver.spec || die "Failed to build rpm."
+rpmbuild -bb ${rpmbuild_openssl} --define "_topdir /rpmbuilddir" --define
"ats_version 9.2.3" /rpmbuilddir/SPECS/trafficserver.spec || die "Failed to
build rpm."
Review Comment:
Reuse %tag instead of hard-coding `9.2.3`?
https://github.com/apache/trafficcontrol/blob/3cd6460cc39afd10b12a01babf12f849d63ceb4f/traffic_server/_tsb/trafficserver.spec#L23
##########
traffic_server/_tsb/repos.yml:
##########
@@ -1,10 +1,8 @@
ats:
src: https://github.com/apache/trafficserver
- branch: 8.0.x
- head: a29528dffb8ea1c6fa57fe0c76ca1ec9d0f08694
- extra:
- - https://github.com/jrushford/trafficserver
- - https://github.com/traeak/trafficserver
+ branch: 9.2.x
+ head: b4e3c73354d2a104ed6f00379eeb9f121a85e8bb # 9.2.3
Review Comment:
9.2.4 is released now ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
