zrhoffman commented on PR #6525: URL: https://github.com/apache/trafficcontrol/pull/6525#issuecomment-2223542707
> This still feels like a step backwards, though. Make is doing its level-best to tell if something needs to be rebuilt, but it's just not quite smart enough to do it - so instead we just give up any kind of change detection? @ocket8888 Yes, because that RPM is not being used for ATS development, it uses ATS release branches. `ATS_SOURCES` does not refer to the source code of ATS, just the sources for this particular build environment, which is pretty mundane. If a developer wanted to test their own ATS dev work in CDN in a Box, they would supply their own RPM, in which case they wouldn't want to use the makefile for the ATS RPM anyway. That's an edge case, though. Most people using CDN in a Box just wand an ATS RPM, any ATS RPM. Recall that, until #5920, we used an ancient ATS RPM from ATS's CI server, it wasn't a `make` goal at all. https://github.com/apache/trafficcontrol/blob/eff8f8fffed29675f6e0c4a2795d0d83efd983ad/infrastructure/cdn-in-a-box/cache/Dockerfile#L76-L77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
