[
https://issues.apache.org/jira/browse/TC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730071#comment-15730071
]
ASF GitHub Bot commented on TC-52:
----------------------------------
Github user dneuman64 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/127#discussion_r91398038
--- Diff: traffic_ops/app/lib/API/Deliveryservice.pm ---
@@ -295,7 +295,7 @@ sub update {
my @response;
push(
@response, {
- "active" => \$rs->active,
+ "active" => $rs->active,
--- End diff --
This is on the update method. When the result set was being returned after
the update, the active flag (and the others with the `\` removed) were not
being rendered correctly. Removing the `\` caused the field to be returned
correctly.
> Integration Tests for TO Client
> -------------------------------
>
> Key: TC-52
> URL: https://issues.apache.org/jira/browse/TC-52
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops Client
> Reporter: David Neuman
> Assignee: David Neuman
> Priority: Blocker
>
> Currently, the traffic ops client relies on unit tests with fixtures for
> validation. This means that a huge assumption is made that the fixture data
> matches what is actually returned from TO. Integration tests should be
> created to validate that the client actually works with TO.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
