[ 
https://issues.apache.org/jira/browse/TC-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767967#comment-15767967
 ] 

ASF GitHub Bot commented on TC-32:
----------------------------------

Github user mitchell852 commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafficcontrol/pull/141#discussion_r93505945
  
    --- Diff: 
traffic_ops/app/lib/Schema/Result/DeliveryServiceInfoForCdnList.pm ---
    @@ -0,0 +1,101 @@
    +
    +#
    +#
    +# Licensed under the Apache License, Version 2.0 (the "License");
    +# you may not use this file except in compliance with the License.
    +# You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +#
    +#
    +
    +package Schema::Result::DeliveryServiceInfoForCdnList;
    +
    +# this view returns the regexp set for a delivery services, ordered by 
type, set_number.
    +# to use, do
    +#
    +# $rs = $self->db->resultset('DeliveryServiceInfoForCdnList')->search({}, 
{ bind => [ $id ]});
    +#
    +# where $id is the CDN id.
    +
    +use strict;
    +use warnings;
    +use utf8;
    +use base 'DBIx::Class::Core';
    +
    +__PACKAGE__->table_class('DBIx::Class::ResultSource::View');
    +
    +__PACKAGE__->table("DeliveryServiceInfoForCdnList:");
    +
    +__PACKAGE__->result_source_instance->is_virtual(1);
    +
    +__PACKAGE__->result_source_instance->view_definition( "
    +SELECT DISTINCT
    --- End diff --
    
    yea, that query is probably going to have to change as I'm guessing it's 
not performant with psql. see this PR where a similar query was rewritten - 
https://github.com/apache/incubator-trafficcontrol/pull/142


> Improve efficiency of ATS config generation
> -------------------------------------------
>
>                 Key: TC-32
>                 URL: https://issues.apache.org/jira/browse/TC-32
>             Project: Traffic Control
>          Issue Type: Improvement
>          Components: Traffic Ops API
>            Reporter: Derek Gelinas
>            Assignee: Derek Gelinas
>             Fix For: 1.9.0
>
>
> Currently when generating ATS configuration files, each server calls for its 
> individual files from traffic ops.  This is a very database-intensive process 
> that is not scalable enough.  I propose the following changes:
> 1) Generate the configuration files only as many times as needed - many files 
> are the same (or can be) for the entire CDN or server profile.
> 2) Once generated, the files can be cached locally.  Requests for the files 
> by ORT will result in pulling down these cached files rather than many 
> hundreds of DB queries each time.
> 3) Migrate the routes for these files to the API.  Each call will have 
> multiple options - a request made with no options would return the cached 
> file, another option would return the current DB data, and a third option 
> would update the cached file with the current information in the DB.
> 4) When an update is queued, generate and cache the configuration files, then 
> activate the update flag for the relevant servers once the cached file 
> generation is completed.
> In this way, triggering updates for the caches will result in an initial 
> increase in activity as traffic ops generates the files needed, followed by 
> the much lower impact of the files themselves being requested by the caches.
> I believe we can cut down the number of server-specific configuration files 
> to only 5 intially, and potentially fewer by having ORT fill in certain 
> fields on files like records.config with local data during processing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to