[
https://issues.apache.org/jira/browse/TC-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798711#comment-15798711
]
ASF GitHub Bot commented on TC-39:
----------------------------------
GitHub user dangogh opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/156
[TC-39] More apache compliance
Remove goose binary and Perl modules -- now installed by the rpm spec file
and not delivered with traffic_ops.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dangogh/incubator-trafficcontrol
apache-compliance
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit 568bf3e598d1bd5f1022d638eb78b58a230d499e
Author: Dan Kirkwood <[email protected]>
Date: 2017-01-03T17:38:07Z
remove goose binary
commit 32f5ff6dbfd48bb478b7aa5077dc70596100e4d1
Author: Dan Kirkwood <[email protected]>
Date: 2017-01-03T20:15:42Z
remove Perl-licensed files
commit 9994222ccb1268c23768a3523391d90d1f2e0d80
Author: Dan Kirkwood <[email protected]>
Date: 2017-01-04T05:02:29Z
adds perl modules needed for postinstall to rpm install
commit 1a7516a90be2b76a7338fe0c2cb9aeed510f221c
Author: Dan Kirkwood <[email protected]>
Date: 2017-01-04T05:10:14Z
run cpanm with tests turned off
commit 8d6735153187636dc175e264b5b89d66482f2672
Author: Dan Kirkwood <[email protected]>
Date: 2017-01-04T15:06:05Z
install goose from rpm spec
commit f41eb9b8dcd03be63912f70cbf44714a5585ded2
Author: Dan Kirkwood <[email protected]>
Date: 2017-01-04T15:17:57Z
add go to rpm requirements
commit 1372bd2ad8ed5c2b04695d70d6b4f17873e9b53b
Author: Dan Kirkwood <[email protected]>
Date: 2017-01-04T16:05:00Z
add git to rpm install
----
> LICENSE file is incomplete
> --------------------------
>
> Key: TC-39
> URL: https://issues.apache.org/jira/browse/TC-39
> Project: Traffic Control
> Issue Type: Bug
> Reporter: Eric Friedrich
> Priority: Minor
> Fix For: 1.8.0
>
>
> Our LICENSE file only includes Apache License, but not the licenses of all
> our bundled dependencies.
> From
> https://incubator.apache.org/guides/releasemanagement.html#best-practice-license:
> bq. "All the licenses on all the files to be included within a package should
> be included in the LICENSE document. This LICENSE (courtesy of Apache HTTPD)
> is a good example. The Apache License is at the top of the LICENSE document.
> After that, the license for each non-Apache licensed component is included,
> along with a clear explanation of which files that license applies to."
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
