[
https://issues.apache.org/jira/browse/TC-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805946#comment-15805946
]
ASF GitHub Bot commented on TC-6:
---------------------------------
Github user dangogh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/126#discussion_r95029992
--- Diff: traffic_ops/install/bin/postinstall-new ---
@@ -0,0 +1,781 @@
+#!/usr/bin/perl
+
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+use lib qw(/opt/traffic_ops/install/lib /opt/traffic_ops/install/lib/perl5
/opt/traffic_ops/app/local/lib/perl5 /opt/traffic_ops/app/lib);
+$ENV{PATH} = "/opt/traffic_ops/install/bin:$ENV{PATH}";
+$ENV{PERL5LIB} =
"/opt/traffic_ops/install/lib:/opt/traffic_ops/install/lib/perl5:/opt/traffic_ops/app/local/lib/perl5:/opt/traffic_ops/app/lib";
+
+use strict;
+use warnings;
+
+use Safe;
+use POSIX;
+use File::Basename qw{dirname};
+use File::Path qw{make_path};
+use InstallUtils qw{ :all };
+use BuildPerlDeps qw{ :all };
+use GenerateCert qw{ :all };
+use ProfileCleanup qw { :all };
+use Digest::SHA1 qw(sha1_hex);
+use Data::Dumper qw(Dumper);
+use Scalar::Util qw(looks_like_number);
+use Getopt::Long;
+
+# paths of the output configuration files
+our $databaseConfFile =
"/opt/traffic_ops/app/conf/production/database.conf";
--- End diff --
No reason to use "our" -- here -- sharing package variables makes it hard
to follow the code.
> Traffic Ops postinstall: non-interactive configuration
> ------------------------------------------------------
>
> Key: TC-6
> URL: https://issues.apache.org/jira/browse/TC-6
> Project: Traffic Control
> Issue Type: Improvement
> Components: Traffic Ops
> Affects Versions: 1.8.0
> Reporter: Dan Kirkwood
> Assignee: Dan Kirkwood
> Attachments: Automated_Postinstall_for_Traffic_Ops_v4.docx
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Traffic Ops postinstall currently requires interactive user input. This
> makes it difficult to install exactly the same way each time, and can be
> error prone. It also makes installation within a docker container difficult.
> There should be a way to get this same input from a file that can be
> configured ahead of time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
