GitHub user weifensh opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/176
Fix TC-44: TR fd leak observed when new HTTPS DS is added without cert
@dneuman64 @trevorackerman Could you help to review? thanks.
The RC is that the certificate waiting loop blocks the threads which shall
process the HTTP responses from TM.
More details for RC at : https://issues.apache.org/jira/browse/TC-44
The fix is to avoid the waiting loop. Thus all the CrConfig will be loaded
even if there is an HTTPS delivery service which does not have cert/key. For
such a DS, TR will close the TCP connection when a request comes.
At Slack, I got from David that not loading a CrConfig for no cert HTTPS DS
is to be consistent with the behavior of DNSSEC. But loading the CrConfig for
such a DS does not seem to affect much as the requests to this DS still got
banned. Could you help to comment?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weifensh/incubator-trafficcontrol
master-https-fd
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit 4999810666a1483492e3d208ae7016a73632883e
Author: John Shen <weife...@cisco.com>
Date: 2017-01-11T08:09:45Z
Fix TC-44: TR fd leak observed when new HTTPS DS is added without
certificate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
