Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/243#discussion_r99145205
--- Diff: traffic_ops/app/lib/UI/DeliveryService.pm ---
@@ -78,7 +78,8 @@ sub get_cdn_domain {
distinct => 1
}
)->get_column('value')->single();
- return $cdn_domain;
+ # Always return a lowercase FQDN.
+ return lc($cdn_domain);
--- End diff --
does it make sense to lowercase the response from these methods too?
https://github.com/elsloo/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/MojoPlugins/DeliveryService.pm#L213
https://github.com/elsloo/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/MojoPlugins/DeliveryService.pm#L230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
