[
https://issues.apache.org/jira/browse/TC-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879091#comment-15879091
]
ASF GitHub Bot commented on TC-159:
-----------------------------------
GitHub user limited opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/301
TC-159 Remove AL2 from traffic_monitor_config.js
JSON files do not support comments.
This PR does not need to be merged unless another 1.8 RC will be cut
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/limited/incubator-trafficcontrol TC-159
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #301
----
commit b445dad9e38672dbf2e8c09eba4cbe2214f740f5
Author: Eric Friedrich <limi...@users.noreply.github.com>
Date: 2017-02-22T19:43:49Z
TC-159: Remove AL2 from traffic_monitor_config.js
commit 0f52ab241d33575e0806e8444c7999e023017fbc
Author: Eric Friedrich <limi...@users.noreply.github.com>
Date: 2017-02-22T19:50:19Z
TC-159: Remove AL2 from JSON header
----
> traffic_monitor_config.js is corrupt.
> -------------------------------------
>
> Key: TC-159
> URL: https://issues.apache.org/jira/browse/TC-159
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Monitor
> Affects Versions: 1.8.0
> Reporter: Chris Lemmons
> Assignee: Eric Friedrich
> Priority: Minor
> Labels: easyfix
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The traffic_monitor_config.js file that is installed with the RPM is invalid.
> The license header comment was added to the top of the file, but JSON files
> aren't legally allowed to have comments, so the file fails to load.
> Workaround: Remove the header and everything runs fine.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
