Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/322#discussion_r103547240
--- Diff: traffic_ops/app/t/api/1.2/tenant.t ---
@@ -0,0 +1,156 @@
+package main;
+#
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use Mojo::Base -strict;
+use Test::More;
+use Test::Mojo;
+use DBI;
+use strict;
+use warnings;
+no warnings 'once';
+use warnings 'all';
+use Test::TestHelper;
+
+#no_transactions=>1 ==> keep fixtures after every execution, beware of
duplicate data!
+#no_transactions=>0 ==> delete fixtures after every execution
+
+BEGIN { $ENV{MOJO_MODE} = "test" }
+
+my $schema = Schema->connect_to_database;
+my $dbh = Schema->database_handle;
+my $t = Test::Mojo->new('TrafficOps');
+
+my $false = 0;
+my $true = 1;
+
+Test::TestHelper->unload_core_data($schema);
+Test::TestHelper->load_core_data($schema);
+
+ok $t->post_ok( '/login', => form => { u => Test::TestHelper::ADMIN_USER,
p => Test::TestHelper::ADMIN_USER_PASSWORD } )->status_is(302)
+ ->or( sub { diag $t->tx->res->content->asset->{content}; } ), 'Should
login?';
+
+#verifying the basic cfg
+$t->get_ok("/api/1.2/tenants")->status_is(200)->json_is(
"/response/0/name", "root" )->or( sub { diag
$t->tx->res->content->asset->{content}; } );;
+
+my $root_tenant_id = &get_tenant_id('root');
+
+#setting with no "active" field which is optional
+ok $t->post_ok('/api/1.2/tenants' => {Accept => 'application/json'} =>
json => {
+ "name" => "tenantA", "parentId" => $root_tenant_id
})->status_is(200)->or( sub { diag $t->tx->res->content->asset->{content}; } )
+ ->json_is( "/response/name" => "tenantA" )
+ ->json_is( "/response/active" => $false)
+ ->json_is( "/response/parentId" => $root_tenant_id)
+ , 'Does the tenant details return?';
+
+#same name - would not accept
+ok $t->post_ok('/api/1.2/tenants' => {Accept => 'application/json'} =>
json => {
+ "name" => "tenantA", "active" => $true, "parentId" =>
$root_tenant_id })->status_is(400);
+
+#no name - would not accept
+ok $t->post_ok('/api/1.2/tenants' => {Accept => 'application/json'} =>
json => {
+ "parentId" => $root_tenant_id })->status_is(400);
+
+#no parent - would not accept
+ok $t->post_ok('/api/1.2/tenants' => {Accept => 'application/json'} =>
json => {
+ "name" => "tenantB" })->status_is(400);
+
+my $tenantA_id = &get_tenant_id('tenantA');
+#rename, and move to active
+ok $t->put_ok('/api/1.2/tenants/' . $tenantA_id => {Accept =>
'application/json'} => json => {
+ "name" => "tenantA2", "active" => $true, "parentId" =>
$root_tenant_id
+ })
+ ->status_is(200)->or( sub { diag
$t->tx->res->content->asset->{content}; } )
+ ->json_is( "/response/name" => "tenantA2" )
+ ->json_is( "/response/id" => $tenantA_id )
+ ->json_is( "/response/active" => $true )
+ ->json_is( "/response/parentId" => $root_tenant_id )
+ ->json_is( "/alerts/0/level" => "success" )
+ , 'Does the tenantA2 details return?';
+
+#change "active"
+ok $t->put_ok('/api/1.2/tenants/' . $tenantA_id => {Accept =>
'application/json'} => json => {
+ "name" => "tenantA2", "active" => $false, "parentId" =>
$root_tenant_id
+ })
+ ->status_is(200)->or( sub { diag
$t->tx->res->content->asset->{content}; } )
+ ->json_is( "/response/name" => "tenantA2" )
+ ->json_is( "/response/id" => $tenantA_id )
+ ->json_is( "/response/active" => $false )
+ ->json_is( "/response/parentId" => $root_tenant_id )
+ ->json_is( "/alerts/0/level" => "success" )
+ , 'Did we moved to non active?';
+
+#change "active" back
+ok $t->put_ok('/api/1.2/tenants/' . $tenantA_id => {Accept =>
'application/json'} => json => {
+ "name" => "tenantA2", "active" => $true, "parentId" =>
$root_tenant_id
+ })
+ ->status_is(200)->or( sub { diag
$t->tx->res->content->asset->{content}; } )
+ ->json_is( "/response/name" => "tenantA2" )
+ ->json_is( "/response/id" => $tenantA_id )
+ ->json_is( "/response/active" => $true )
+ ->json_is( "/response/parentId" => $root_tenant_id )
+ ->json_is( "/alerts/0/level" => "success" )
+ , 'Did we moved back to active?';
+
+#cannot change tenant parent to undef
+ok $t->put_ok('/api/1.2/tenants/' . $tenantA_id => {Accept =>
'application/json'} => json => {
+ "name" => "tenantC",
+ })->status_is(400);
+
+#cannot change root-tenant to inactive
+ok $t->put_ok('/api/1.2/tenants/' . $root_tenant_id => {Accept =>
'application/json'} => json => {
+ "name" => "root", "active" => $false, "parentId" =>
undef
+ })->status_is(400);
+
+#adding a child tenant
+ok $t->post_ok('/api/1.2/tenants' => {Accept => 'application/json'} =>
json => {
+ "name" => "tenantD", "active" => $true, "parentId" => $tenantA_id
})->status_is(200)->or( sub { diag $t->tx->res->content->asset->{content}; } )
+ ->json_is( "/response/name" => "tenantD" )
+ ->json_is( "/response/active" => $true )
+ ->json_is( "/response/parentId" => $tenantA_id)
+ , 'Does the tenant details return?';
+
+#adding a child inactive tenant
+ok $t->post_ok('/api/1.2/tenants' => {Accept => 'application/json'} =>
json => {
+ "name" => "tenantE", "active" => $false, "parentId" => $tenantA_id
})->status_is(200)->or( sub { diag $t->tx->res->content->asset->{content}; } )
+ ->json_is( "/response/name" => "tenantE" )
+ ->json_is( "/response/active" => $false )
+ ->json_is( "/response/parentId" => $tenantA_id)
+ , 'Does the tenant details return?';
+
+#cannot delete a tenant that have children
+ok $t->delete_ok('/api/1.2/tenants/' . $tenantA_id)->status_is(500);
--- End diff --
Added to my to do list - improve later on
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
