Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@dangogh @alficles Yes, traffic_monitor and traffic_monitor_golang should
never both be built. One is replacing the other. The plan is to rename the
`traffic_monitor_golang` directory to `traffic_monitor` and remove the old
`traffic_monitor` once it's stable. Until we change the name and officially
"replace" the old one, Docker Compose shouldn't build
`traffic_monitor_golang`.
+1 on commenting it. Leaving in there and commented will make it easier for
those of us testing the new version.
On Fri, Mar 3, 2017 at 8:01 AM, alficles <[email protected]> wrote:
> This is a marked improvement, but it introduces a new issue: make clean.
> Since the build is happening directly in the local directories, all the
> temporary files will be left around. There's two ways around this, either
> copy the entire build folder into a new directory inside the container and
> just copy the final binaries out, or introduce a cleaning functionality
> that will remove the intermediate files.
>
> I like the second option better, but the first is significantly easier, I
> think.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-trafficcontrol/pull/327#issuecomment-283976269>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AE4GTdGNvkayhST2qZAkDrL6ZCbQRVukks5riCtJgaJpZM4MQARS>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
