Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/299#discussion_r106269894
--- Diff: traffic_ops/app/lib/UI/Server.pm ---
@@ -980,7 +1018,14 @@ sub postupdate {
my $update_server =
$self->db->resultset('Server')->search( { id => $serverid } );
- if ( defined $updated ) {
+
+ my $use_reval_pending = $self->db->resultset('Parameter')->search( {
-and => [ 'name' => 'use_reval_pending', 'config_file' => 'global' ] }
)->get_column('value')->single;
+
+ if ( defined($use_reval_pending) && $use_reval_pending == 1 ) {
--- End diff --
you can save a few lines of code here by getting rid of the else and moving
$update_server->update( { upd_pending => $updated } );
below the remaining if...and also leave it out of the if...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
