GitHub user rob05c opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/428

    Deprecate TO client ResumeSession, remove juju dependency

    Changes the TO client ResumeSession to always return nil and an error
    as if the persisted cookie had expired, and adds a Deprecated comment
    indicating it will be removed in the next version.
    
    This allows us to remove the juju persistent cookie dependency, which
    has an incompatible license.
    
    It also seems reasonable to deprecate and remove ResumeSession, as
    Traffic Control itself doesn't use it, and any users would need logic
    to handle expired cookies and do an ordinary Login anyway, which is
    not an expensive operation.
    
    TC-119 #close

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rob05c/incubator-trafficcontrol 
to-deprecateresumesession

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #428
    
----
commit 5736ec732047a0abd4fc5a8b7eadf93f855d2aa3
Author: Robert Butts <[email protected]>
Date:   2017-04-05T04:28:15Z

    Deprecate TO client ResumeSession, remove juju dep
    
    Changes the TO client ResumeSession to always return nil and an error
    as if the persisted cookie had expired, and adds a Deprecated comment
    indicating it will be removed in the next version.
    
    This allows us to remove the juju persistent cookie dependency, which
    has an incompatible license.
    
    It also seems reasonable to deprecate and remove ResumeSession, as
    Traffic Control itself doesn't use it, and any users would need logic
    to handle expired cookies and do an ordinary Login anyway, which is
    not an expensive operation.
    
    TC-119 #close

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to