Github user alficles commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafficcontrol/pull/425#discussion_r111804555
  
    --- Diff: traffic_monitor_golang/traffic_monitor/datareq/datareq.go ---
    @@ -235,3 +276,39 @@ func addTrailingSlashEndpoints(dispatchMap 
map[string]http.HandlerFunc) map[stri
        }
        return dispatchMap
     }
    +
    +func acceptsGzip(r *http.Request) bool {
    +   encodingHeaders := r.Header["Accept-Encoding"] // headers are 
case-insensitive, but Go promises to Canonical-Case requests
    +   for _, encodingHeader := range encodingHeaders {
    +           encodingHeader := strings.Replace(encodingHeader, " ", "", -1)
    --- End diff --
    
    This is incorrect. These headers have optional linear whitespace included, 
which can be spaces, tabs, or a CRLF, as long as it is followed by a space or a 
tab.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to