Github user nir-sopher commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/403
@mitchell852 Please note that after rebasing the branch deliveryservice UT
fail.
For some reason the changes I do does not work well with the changes you
did, moving from &UI::DeliveryService::get_regexp_set to $self->get_regexp_set.
Any clue why?
When I'm making the below change the UT passes
@@ -69,7 +69,7 @@ sub index {
# build example urls for each delivery service
my @example_urls = ();
my $cdn_domain = $row->cdn->domain_name;
- my $regexp_set = $self->get_regexp_set(
$row->deliveryservice_regexes );
+ my $regexp_set = &UI::DeliveryService::get_regexp_set(
$self, $row->id );
@example_urls = &UI::DeliveryService::get_example_urls(
$self, $row->id, $regexp_set, $row, $cdn_domain, $row->protocol );
push(
@@ -172,7 +172,7 @@ sub show {
# build example urls for the delivery service
my @example_urls = ();
my $cdn_domain = $row->cdn->domain_name;
- my $regexp_set = $self->get_regexp_set(
$row->deliveryservice_regexes );
+ my $regexp_set = &UI::DeliveryService::get_regexp_set(
$self, $row->id );
@example_urls = &UI::DeliveryService::get_example_urls(
$self, $row->id, $regexp_set, $row, $cdn_domain, $row->protocol );
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
