Github user dangogh commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafficcontrol/pull/535#discussion_r114338121
  
    --- Diff: traffic_ops/app/lib/UI/ConfigFiles.pm ---
    @@ -852,18 +852,47 @@ sub hosting_dot_config {
        return $text;
     }
     
    -sub storage_dot_config_volume_text {
    +sub storage_dot_config_letter_to_id_mapping($$@) {
    +   my $letters      = shift;        
    +   my $hash_key_ids = shift;        
    +   my @postfix      = @_;
    +   my %mapping;                                            
    +                                                            
    +   if (defined($hash_key_ids)) {                           
    +           my @tmp_list = split( /,/, $hash_key_ids);          
    +                                                            
    +           # find the minimum of the two list sizes
    --- End diff --
    
    just spent 5 minutes figuring out what this method is doing.   Figured that 
out,  but I still don't know why -- comments needed,  please....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to