Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129904376
--- Diff: traffic_ops/app/lib/API/DeliveryServiceMatches.pm ---
@@ -28,11 +29,19 @@ sub index {
my $format = $self->param("format") || "";
my $rs;
- if ( &is_privileged($self) ) {
+ # TO the reviewer: Do we need to override the "is_priviledged" here byt
the standard "ignore_ds_user_table" flag?
+ # What is the reason of the is_priv test - was someone just dussmissed
the ds_tmuser table tests
+ if ( &is_privileged($self)) {
--- End diff --
what about if you change this line to:
if ( (use-tenancy=1) || &is_privileged($self)) {
^^ that's just pseudo code obviously
if tenancy is in place, fine let them in and you will only see "matches"
for the ds's assigned to you
if tenancy is not in place, then it will fall back to what it was before
and will check is_privileged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
