Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129928084
--- Diff: traffic_ops/app/lib/API/DeliveryServiceServer.pm ---
@@ -27,6 +28,11 @@ sub index {
my @data;
my $orderby = $self->param('orderby') || "deliveryservice";
+ #FOR THE REVIEWER - Currently I do not check DS tenancy here.
--- End diff --
As I saw it, the ds-admin should not be aware of specific servers
existence, so this API should not be available to him.
However, as you see usecases a ds-admin may approach this API, I'll had the
tenancy check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
